gitea/integrations
zeripath fb5af37b3e
Add Close() method to gogitRepository (#8901) (#8958)
Backport #8901 - Adjusted slightly for 1.9

In investigating #7947 it has become clear that the storage component of go-git repositories needs closing.

This PR adds this Close function and adds the Close functions as necessary.

In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files.

Fixes #7947
2019-11-13 18:51:33 +00:00
..
gitea-repositories-meta Add commit statuses reports on pull request view (#6845) 2019-06-30 08:57:59 +01:00
migration-test Fix dropTableColumns sqlite implementation (#7710) (#7765) 2019-08-06 07:35:54 +03:00
api_admin_org_test.go Fixes #7023 - API Org Visibility (#7028) 2019-05-30 13:57:55 -04:00
api_admin_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_branch_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_comment_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_fork_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_gpg_keys_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_helper_for_declarative_test.go Fix #732: Add LFS objects to base repository on merging (#7082) 2019-06-22 18:35:34 +01:00
api_issue_label_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_issue_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_keys_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_org_test.go Fixes #7023 - API Org Visibility (#7028) 2019-05-30 13:57:55 -04:00
api_pull_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_releases_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
api_repo_edit_test.go Fixes #5960 - Adds API Endpoint for Repo Edit (#7006) 2019-05-30 11:09:05 -04:00
api_repo_file_create_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
api_repo_file_delete_test.go Fixes #7152 - Allow create/update/delete message to be empty, use default message (#7324) 2019-06-29 16:19:24 +01:00
api_repo_file_helpers.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_repo_file_update_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
api_repo_get_contents_list_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
api_repo_get_contents_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
api_repo_git_blobs_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_repo_git_commits_test.go Add single commit API support (#5843) 2019-02-02 22:35:17 -05:00
api_repo_git_hook_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_repo_git_ref_test.go Implement git refs API for listing references (branches, tags and other) (#5354) 2018-11-27 16:52:20 -05:00
api_repo_git_tags_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
api_repo_git_trees_test.go Fixes 4762 - Content API for Creating, Updating, Deleting Files (#6314) 2019-04-17 12:06:35 -04:00
api_repo_lfs_locks_test.go lfs/lock: round locked_at timestamp to second (#7872) (#7875) 2019-08-15 18:53:20 +08:00
api_repo_raw_test.go Enforce token on api routes [fixed critical security issue #4357] (#4840) 2018-09-10 12:15:52 -04:00
api_repo_tags_test.go Fixes #2738 - Adds the /git/tags API endpoint (#7138) 2019-06-08 17:31:11 +03:00
api_repo_test.go SearchRepositoryByName improvements and unification (#6897) 2019-05-15 11:24:39 -04:00
api_team_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_team_user_test.go Hide some user information via API if user have no enough permission (#8655) (#8658) 2019-10-24 09:01:40 +03:00
api_token_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_user_heatmap_test.go Update heatmap fixtures to restore tests (#8615) (#8617) 2019-10-21 22:19:27 +01:00
api_user_orgs_test.go Fixes #7023 - API Org Visibility (#7028) 2019-05-30 13:57:55 -04:00
api_user_search_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
auth_ldap_test.go Fix issue where ecdsa and other key types are not synced from LDAP (#5092) (#5094) 2018-10-30 20:08:30 -04:00
benchmarks_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
branches_test.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
change_default_branch_test.go Less verbose integration tests (#2123) 2017-07-07 21:36:47 +02:00
cors_test.go Handle CORS requests (#6289) 2019-05-13 11:38:53 -04:00
create_no_session_test.go Prevent creating empty sessions (#6677) 2019-04-20 07:44:50 +01:00
delete_user_test.go Refactor User Settings (#3900) 2018-05-15 13:07:32 +03:00
download_test.go Allow markdown files to read from the LFS (#5787) 2019-02-12 15:09:43 +00:00
editor_test.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
empty_repo_test.go Refactor repo.isBare to repo.isEmpty #5629 (#5714) 2019-01-17 19:01:04 -05:00
explore_repos_test.go fix template error on explore repos (#2319) 2017-08-17 15:20:21 +03:00
git_helper_for_declarative_test.go Restore functionality for early gits (#7775) (#8476) 2019-10-13 12:40:13 +08:00
git_test.go Restore functionality for early gits (#7775) (#8476) 2019-10-13 12:40:13 +08:00
html_helper.go Use httptest in integration tests (#3080) 2017-12-04 00:46:01 +02:00
integration_test.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
issue_test.go Unit tests for routers/repo/issue_label (#3198) 2017-12-15 23:11:02 +02:00
lfs_getobject_test.go Restore functionality for early gits (#7775) (#8476) 2019-10-13 12:40:13 +08:00
links_test.go refactor: append, build variable and type switch (#4940) 2019-05-28 23:45:54 +08:00
mssql.ini.tmpl Quieter Integration Tests (#6513) 2019-04-07 03:25:14 +03:00
mysql8.ini.tmpl Quieter Integration Tests (#6513) 2019-04-07 03:25:14 +03:00
mysql.ini.tmpl Quieter Integration Tests (#6513) 2019-04-07 03:25:14 +03:00
nonascii_branches_test.go Fix redirect with non-ascii branch names (#4764) (#4810) 2018-09-06 21:37:02 -04:00
oauth_test.go Add json tags for oauth2 form (#6627) 2019-04-15 11:54:50 -04:00
org_test.go Allow collaborators to view repo owned private org (#6965) 2019-05-16 11:48:40 -04:00
pgsql.ini.tmpl Quieter Integration Tests (#6513) 2019-04-07 03:25:14 +03:00
pull_compare_test.go Responsive view (#2750) 2017-12-30 18:47:52 -06:00
pull_create_test.go Remove local clones & make hooks run on merge/edit/upload (#6672) 2019-05-11 11:29:17 -04:00
pull_merge_test.go Fix duplicate call of webhook (#7821) (#7824) 2019-08-12 09:53:26 +08:00
pull_review_test.go fix 500 when reviewer is deleted with integration tests (#6856) 2019-05-06 20:09:31 +08:00
pull_status_test.go Fix pull creation with empty changes (#7920) (#7926) 2019-08-20 22:14:09 -04:00
README_ZH.md CN translation of README (#5050) 2018-10-15 12:13:21 +08:00
README.md CN translation of README (#5050) 2018-10-15 12:13:21 +08:00
release_test.go Fix prohibit login check on authorization (#6106) 2019-02-19 09:19:28 +02:00
repo_activity_test.go Remove local clones & make hooks run on merge/edit/upload (#6672) 2019-05-11 11:29:17 -04:00
repo_branch_test.go Remove local clones & make hooks run on merge/edit/upload (#6672) 2019-05-11 11:29:17 -04:00
repo_commits_search_test.go Support search operators for commits search (#6479) 2019-04-12 10:28:44 +08:00
repo_commits_test.go api: fix multiple bugs with statuses endpoints (#7785) (#7807) 2019-08-09 16:18:46 +03:00
repo_fork_test.go Use httptest in integration tests (#3080) 2017-12-04 00:46:01 +02:00
repo_migrate_test.go Add more bench (#3161) 2017-12-24 02:33:34 +02:00
repo_search_test.go Change UpdateRepoIndex api to include watchers (#7012) 2019-05-23 17:00:07 +01:00
repo_test.go Refactor table width to have more info shown in file list (#6867) 2019-05-06 21:43:40 +03:00
repofiles_delete_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
repofiles_update_test.go Add Close() method to gogitRepository (#8901) (#8958) 2019-11-13 18:51:33 +00:00
setting_test.go Show email if the authenticated user owns the profile page being requested for (#4981) 2019-02-19 09:11:50 -05:00
signin_test.go Add integration tests for signin (#2363) 2017-08-23 10:30:33 +03:00
signout_test.go Add integration test for logging out (#2892) 2017-11-11 23:29:07 -06:00
signup_test.go Less verbose integration tests (#2123) 2017-07-07 21:36:47 +02:00
sqlite.ini Quieter Integration Tests (#6513) 2019-04-07 03:25:14 +03:00
ssh_key_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
testlogger.go Fix data race (#8206) 2019-09-17 12:40:28 +03:00
timetracking_test.go Unit tests for routers/repo/issue_label (#3198) 2017-12-15 23:11:02 +02:00
user_test.go add .gpg url (match github behaviour) (#6610) 2019-04-14 12:43:56 -04:00
version_test.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
xss_test.go Added user language setting (#3875) 2018-05-05 08:28:30 +08:00

Integrations tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-mysql
make test-pgsql
make test-sqlite

Make sure to perform a clean build before running tests:

make clean build

Run all tests via local drone

drone exec --local --build-event "pull_request"

Run sqlite integrations tests

Start tests

make test-sqlite

Run mysql integrations tests

Setup a mysql database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" --rm --name mysql mysql:5.7 #(just ctrl-c to stop db and clean the container) 

Start tests based on the database container

TEST_MYSQL_HOST="$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' mysql):3306" TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integrations tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" --rm --name pgsql postgres:9.5 #(just ctrl-c to stop db and clean the container) 

Start tests based on the database container

TEST_PGSQL_HOST=$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' pgsql) TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Running individual tests

Example command to run GPG test with sqlite backend:

go test -c code.gitea.io/gitea/integrations \
  -o integrations.sqlite.test -tags 'sqlite' &&
  GITEA_ROOT="$GOPATH/src/code.gitea.io/gitea" \
  GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test \
  -test.v -test.run GPG